-
Notifications
You must be signed in to change notification settings - Fork 390
Update sub-ice-shelf melt to remove coupled flag #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sub-ice-shelf melt to remove coupled flag #164
Conversation
The melt computation is never called with the fields from the ice sheet (this will be handled in the coupler instead) so there is no value in keeping this code. We have the past history if it is ever needed in aiding coupler development.
TestingI ran all but the QU120wLI test case from the land-ice-fluxes test suite. (The QU120 uses more cores than my laptop has.) All tests passed and are bit-for-bit identical to @mark-petersen, could you run both nightly and land-ice-fluxes regression tests (compared with |
|
BTW, I will hesitate to do ocean clean-up pull requests in the future because of the hideous green/blue color combination of the tags :-p |
|
@mark-petersen, this needs attention only so it doesn't languish too long. It's simply to remove some buggy and unused code. |
mark-petersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar thanks for your attention to clean-up. This looks good. Tested with gnu and intel/debug, with land ice nightly regression test.
I will merge in with next E3SM update, for bfb changes.
…to ocean/develop The melt computation is never called with the fields from the ice sheet (this will be handled in the coupler instead) so there is no value in keeping this code. We have the past history if it is ever needed in aiding coupler development. closes MPAS-Dev#163
Includes: 1. LIGHT update (MPAS-Ocean Lagrangian particles): MPAS-Dev/MPAS-Model#56 2. clean up ice shelf melt flag: MPAS-Dev/MPAS-Model#164 3. merge coastal branch: MPAS-Dev/MPAS-Model#54 4. CONUS mesh update: MPAS-Dev/MPAS-Model#201 5. Major COMPASS upgrade to python 3: MPAS-Dev/MPAS-Model#229 6. Eliminate outdated -DUNDERSCORE flag: MPAS-Dev/MPAS-Model#156 7. PIO Version Compatibility Check - PGI Compiler Bug Fix: MPAS-Dev/MPAS-Model#212 These changes do not alter E3SM standard cases or testing on next. COMPASS is the MPAS testing infrastructure. LIGHT and coastal changes are protected by flags and not used in normal E3SM tests.
Update mpas source This PR update the mpas-source git submodule but only includes changes that will not impact E3SM. These changes include: * LIGHT update (MPAS-Ocean Lagrangian particles): MPAS-Dev/MPAS-Model#56 * clean up ice shelf melt flag: MPAS-Dev/MPAS-Model#164 * merge coastal branch: MPAS-Dev/MPAS-Model#54 * CONUS mesh update: MPAS-Dev/MPAS-Model#201 * Major COMPASS upgrade to python 3: MPAS-Dev/MPAS-Model#229 * Eliminate outdated -DUNDERSCORE flag: MPAS-Dev/MPAS-Model#156 * PIO Version Compatibility Check - PGI Compiler Bug Fix: MPAS-Dev/MPAS-Model#212 These changes do not alter E3SM standard cases or tested configurations. COMPASS is the MPAS testing infrastructure. LIGHT and coastal changes are protected by flags and not used in normal E3SM tests. [NML] [BFB]
Update mpas source This PR update the mpas-source git submodule but only includes changes that will not impact E3SM. These changes include: * LIGHT update (MPAS-Ocean Lagrangian particles): MPAS-Dev/MPAS-Model#56 * clean up ice shelf melt flag: MPAS-Dev/MPAS-Model#164 * merge coastal branch: MPAS-Dev/MPAS-Model#54 * CONUS mesh update: MPAS-Dev/MPAS-Model#201 * Major COMPASS upgrade to python 3: MPAS-Dev/MPAS-Model#229 * Eliminate outdated -DUNDERSCORE flag: MPAS-Dev/MPAS-Model#156 * PIO Version Compatibility Check - PGI Compiler Bug Fix: MPAS-Dev/MPAS-Model#212 These changes do not alter E3SM standard cases or tested configurations. COMPASS is the MPAS testing infrastructure. LIGHT and coastal changes are protected by flags and not used in normal E3SM tests. [NML] [BFB]
…to ocean/develop The melt computation is never called with the fields from the ice sheet (this will be handled in the coupler instead) so there is no value in keeping this code. We have the past history if it is ever needed in aiding coupler development. closes MPAS-Dev#163
…to ocean/develop The melt computation is never called with the fields from the ice sheet (this will be handled in the coupler instead) so there is no value in keeping this code. We have the past history if it is ever needed in aiding coupler development. closes MPAS-Dev#163
* Update version number to 8.3.1 * Fix bug in vertical interp of humidity for LBCs when levels are given top-to-bottom Note: The changes in this commit mirror those in commit f232665, but this commit concerns to the code for producing LBCs rather than the code for producing ICs. The code in the init_atm_case_lbc routine for vertically interpolating relative humidity and specific humidity for LBCs assumed that first-guess levels would be given in bottom-to-top order when attempting to vertically extrapolate to model levels below the lowest first-guess level. The relevant code for relative humidity read as follows -- the code for specific humidity is similar. if (target_z < z_fg(1,iCell) .and. k < nVertLevels) relhum(k,iCell) = relhum(k+1,iCell) If first-guess levels are not given in bottom-to-top order, then z_fg(1,iCell) does not necessarily contain the height of the surface in the first-guess data, resulting in a copy of vertically interpolated relative humidity level k+1 to level k. One possible fix for this issue might be to compare target_z with sorted_arr(1,1). Since sorted_arr is always sorted in ascending order by its first index, the check to decide when to copy/extrapolate relative humidity would be independent of the order in which first-guess levels were provided. If the comparison were to be made against sorted_arr(1,1) rather than against z_fg(1,iCell), the effect would be to copy the lowest *interpolated* level downward to model levels below the first-guess ground. An alternative fix adopted in this commit is to simply delete the logic to explicitly copy/extrapolate downward, since both relative humidity and specific humidity are vertically interpolated with extrap=0, which specifies constant- value extrapolation. In this case, the lowest *first-guess* level -- rather than the lowest *interpolated* level -- is copied downward. Note: The issue being addressed by this commit is a dependence on the order in which levels are given in the input intermediate file, and not on the direction in which the first-guess model indexes its levels. * Update MMM-physics tag in Externals.cfg to fix .F90 re-compilation issue This commit updates the tag to 20250616-MPASv8.3 for the MMM-physics external in the src/core_atmosphere/Externals.cfg file to address an issue with .F90 files not being re-compiled to .o files if a .F90 file was modified. With the updated tag, compiling the atmosphere core, then making changes to any of the .F90 files in src/core_atmosphere/physics/physics_mmm/, then running 'make' again (without first cleaning) leads to the modified .F90 files correctly being re-compiled. * Merge gsl/develop * Update version, sync SMOKE submodule * Updating submodule pointers --------- Co-authored-by: Michael Duda <duda@ucar.edu>
The melt computation is never called with the fields from the ice sheet (this will be handled in the coupler instead) so there is no value in keeping this code. We have the past history if it is ever needed in aiding coupler development.
closes #163