This change updates the core_init_atmosphere cmake file to add new files#1317
Closed
jim-p-w wants to merge 1 commit intoMPAS-Dev:developfrom
Closed
This change updates the core_init_atmosphere cmake file to add new files#1317jim-p-w wants to merge 1 commit intoMPAS-Dev:developfrom
jim-p-w wants to merge 1 commit intoMPAS-Dev:developfrom
Conversation
added in commit d2c0680 (PR MPAS-Dev#1276). That PR updated the makefiles, but not the cmake files. That resulted in compile errors when building with cmake: src/core_init_atmosphere/mpas_init_atm_cases.F:48:11: 48 | use mpas_init_atm_gwd_gsl, only : calc_gsl_oro_data | 1 Fatal Error: Cannot open module file 'mpas_init_atm_gwd_gsl.mod' for reading at (1): No such file or directory
Contributor
|
@jim-p-w Is the branch name for this PR the same as in #1316? If so, it might be preferable to use a new branch name for this PR, perhaps and which might be confusing. |
amstokely
approved these changes
May 15, 2025
Contributor
Author
|
@mgduda I don't see how to change the source branch for this PR. It appears only the target branch can be changed. I think I will need to create a new PR and close this one? |
Contributor
Author
|
This PR is superseded by #1320. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the core_init_atmosphere cmake file to add new files added in commit d2c0680 (PR #1276).
That PR updated the makefiles, but not the cmake files. That resulted in compile errors when building with cmake:
src/core_init_atmosphere/mpas_init_atm_cases.F:48:11:
48 | use mpas_init_atm_gwd_gsl, only : calc_gsl_oro_data
| 1
Fatal Error: Cannot open module file 'mpas_init_atm_gwd_gsl.mod' for reading at
(1): No such file or directory
Tested by building mpas_bundle.