Fix MPAS-A dycore-only build in version 8.2.0#1221
Fix MPAS-A dycore-only build in version 8.2.0#1221mgduda merged 1 commit intoMPAS-Dev:hotfix-v8.2.1from
Conversation
When building MPAS-A as a dycore, all physics-related components are disabled. An example scenario of this is for use with CAM/CAM-SIMA. However, the MPAS-A registry file in version 8.2.0 contains the following regressions, which cause the dycore-only build to break: * The MPAS-A registry file introduced a new stream, `da_state`, which unconditionally includes variables that exist only when physics are enabled. * The MPAS-A registry file unconditionally includes a new registry file from Noah-MP, which is applicable only when physics are enabled. Fix MPAS-A dycore-only build by guarding the above regions with the `DO_PHYSICS` macro.
src/core_atmosphere/Makefile
Outdated
|
|
||
| # If MPAS_CAM_DYCORE is found in CPPFLAGS, PHYSICS will become undefined automatically | ||
| # | ||
| ifeq ($(findstring MPAS_CAM_DYCORE,$(CPPFLAGS)),) |
There was a problem hiding this comment.
Although I agree that this is a reasonable change in principle, I think it may be outside the scope what we want to include in the v8.2.1 release. My understanding is that CAM's build already ensured that DO_PHYSICS was not defined, and the need for this change may be due to the reuse of makefiles in ongoing work on CAM-SIMA?
There was a problem hiding this comment.
Yes, CAM maintains its own Makefiles so this change is not needed. This change is for CAM-SIMA because it tries to be as close to the upstream MPAS-A as possible.
I have dropped the commit b3fc19a. The PR descriptions were also updated to no longer mention physics being disabled for dycore-only build.
There was a problem hiding this comment.
I fully support creating a separate PR to the develop branch with this MPAS_CAM_DYCORE logic.
kuanchihwang
force-pushed
the
stg/fix-dycore-only-build
branch
from
b3fc19a to
520d165
Compare
gdicker1
left a comment
gdicker1
left a comment
There was a problem hiding this comment.
Looks good to me and builds succeed!
mgduda
left a comment
mgduda
left a comment
There was a problem hiding this comment.
I've verified that the changes in this PR fix dynamics-only builds of stand-alone MPAS-A.
This merge addresses several issues in the MPAS-Atmosphere model and in the MPAS infrastructure. Specific changes in this merge include: * Improved detection of an 'mpi_f08' module (PR #1202), as well as improved detection of netCDF and PnetCDF library paths (PR #1203), in the top-level Makefile. * The addition of a missing dependency in the physics Makefile to correct parallel build issues (PR #1204). * Fixes to the CMake build files used by MPAS-JEDI (PR #1205). * Fixes to double-precision builds of MPAS-Atmosphere (PR #1207, PR #1208). * Correction of the calculation of height AGL used in the computation of 1-km radar reflectivity fields (PR #1213). * Correction of an issue that prevented the MYNN PBL scheme from being used without also using the Thompson aerosol-aware microphysics (PR #1215). * Fixes to allow MPAS-Atmosphere to be built without physics (i.e., dynamics- only builds) (PR #1221). * Various code cleanup and minor corrections (PR #1206, PR #1212, PR #1224, PR #1226).
3 participants
When building MPAS-A as a dycore, all physics-related components are disabled. An example scenario of this is for use with CAM/CAM-SIMA.
However, the MPAS-A registry file in version 8.2.0 contains the following regressions, which cause the dycore-only build to break:
da_state, which unconditionally includes variables that exist only when physics are enabled.This PR fixes MPAS-A dycore-only build by guarding the above regions with the
DO_PHYSICSmacro.For stand-alone MPAS-A, this PR is an NFC (No Functional Change).