Minor bug fix for physics#1214
Closed
ldfowler58 wants to merge 1 commit intoMPAS-Dev:hotfix-v8.2.1from
Closed
Conversation
…anged print statements
"enter/end subroutine init_atm_gocart" with "enter/end subroutine init_atm_thompson_aerosols.
* In ./src/core_atmosphere/physics:
-> in Makefile, added dependency for mpas_atmphys_lsm_nohampfinalize.F.
-> in mpas_atmphys_driver_radiation_sw.F, removed extra deallocate for
variable tao5503d_p in subroutine deallocate_radiation_sw.F
mgduda
requested changes
Aug 6, 2024
Contributor
mgduda
left a comment
mgduda
left a comment
There was a problem hiding this comment.
Since the fixes in this PR are all unrelated, I would suggest we make separate PRs for each of them. The second fix (missing dependency in a Makefile) has been handled by PR #1204, so perhaps just two PRs for the first and third fixes.
Contributor
Author
|
As requested, I made three separate PRs (see PR 124, 1225, and 1226). |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes three minor bug fix:
In ./src/core_init_atmosphere/mpas_init_atm_thompson_aerosols.F, corrected a print statement in subroutine init_atm_thompson_aerosols.
In ./src/core_atmosphere/physics/Makefile, added dependency for mpas_atmphys_lsm_noahmpfinalize.F.
In ./src/core_atmosphere/physics/mpas_atmphys_driver_radiation_sw.F, removed extra deallocate in subroutine deallocate_radiation_sw.