Fixed CMake build for atmosphere core#1205
Merged
mgduda merged 2 commits intoMPAS-Dev:hotfix-v8.2.1from Jul 16, 2024
Merged
Conversation
amstokely
force-pushed
the
atmosphere/fix_cmake
branch
from
c8d7afb to
ab70a66
Compare
amstokely
force-pushed
the
atmosphere/fix_cmake
branch
2 times, most recently
from
a6f7588 to
86dcc65
Compare
mgduda
requested changes
Jul 15, 2024
mgduda
requested changes
Jul 15, 2024
amstokely
force-pushed
the
atmosphere/fix_cmake
branch
from
444965c to
8893dbb
Compare
This commit restores CMake support for the atmosphere core, which broke due to changes made prior to the version 8.2 release. The breaking changes included moving the physics_mmm directory to its own git repository. This is accounted for in CMake by using FetchContent to clone the correct version of the physics_mmm source code directory based on the MPAS model git version. Additionally, this commit builds the noahmp library that was added to the code base. Previously, this library only supported being built with a hardcoded GNU Makefile. This commit also accounts for the new registry preprocessing arguments that make the registry processing core-agnostic. These changes re-enable a seamless build process for the atmosphere core and improve modularity and maintainability.
This commit restores CMake support for the atmosphere core, which broke due to changes made prior to the version 8.2 release. The breaking changes were a result of the addition of mpas_init_atm_thompson_aerosols.F to the init_atmosphere core without updating the CMakeLists.txt. To fix this problem, this file was appended to the list of source files in the init_atmosphere core's CMakeLists.txt.
amstokely
force-pushed
the
atmosphere/fix_cmake
branch
from
8893dbb to
2c3e974
Compare
mgduda
approved these changes
Jul 16, 2024
Contributor
mgduda
left a comment
mgduda
left a comment
There was a problem hiding this comment.
Thanks for these fixes -- all looks good to me!
mgduda
added a commit
that referenced
this pull request
Aug 7, 2024
This merge addresses several issues in the MPAS-Atmosphere model and in the MPAS infrastructure. Specific changes in this merge include: * Improved detection of an 'mpi_f08' module (PR #1202), as well as improved detection of netCDF and PnetCDF library paths (PR #1203), in the top-level Makefile. * The addition of a missing dependency in the physics Makefile to correct parallel build issues (PR #1204). * Fixes to the CMake build files used by MPAS-JEDI (PR #1205). * Fixes to double-precision builds of MPAS-Atmosphere (PR #1207, PR #1208). * Correction of the calculation of height AGL used in the computation of 1-km radar reflectivity fields (PR #1213). * Correction of an issue that prevented the MYNN PBL scheme from being used without also using the Thompson aerosol-aware microphysics (PR #1215). * Fixes to allow MPAS-Atmosphere to be built without physics (i.e., dynamics- only builds) (PR #1221). * Various code cleanup and minor corrections (PR #1206, PR #1212, PR #1224, PR #1226).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to releasing MPAS v8.2.0, several changes necessitated updates to the GNU Makefiles. These changes included:
physics_mmmdirectory from the source code and moving it to its own GitHub repositoryUnfortunately, the CMake build files were not updated accordingly, resulting in the loss of CMake support in MPAS v8.2.
This PR includes the necessary updates to the CMake files, enabling MPAS to be configured and built with CMake. These updates ensure that the latest version of MPAS can be used with
mpas-jediand allow MPAS-Model to be compiled using both GNU and Intel compilation suites.