Summary

Refactored carousel navigation callbacks to use functional state updates, making them stable references that don't change on every index update.

Why this matters

goTo, goToPrev, and goToNext had activeIndex in their dependency arrays. Every slide change recreated these callbacks, causing unnecessary re-renders downstream. Functional updates read the previous state directly, so the callbacks become stable.

Changes

• surfsense_web/components/ui/hero-carousel.tsx: Converted goTo, goToPrev, goToNext to use setActiveIndex((prev) => ...). Removed activeIndex from the autoplay useEffect dependency array (the setTimeout callback already used a functional update). All three useCallback hooks now have empty dependency arrays.

Testing

Carousel behavior is identical - same navigation, same animation direction logic. The direction ref is set inside the functional updater before returning the new index.

Fixes #951

Retargeted to dev per @MODSetter's request.

High-level PR Summary

This PR refactors the hero carousel navigation callbacks (goTo, goToPrev, goToNext) to use functional state updates instead of depending on activeIndex. This optimization makes the callback references stable, preventing unnecessary re-renders in child components whenever the slide index changes. The autoplay effect dependency array is also cleaned up by removing activeIndex since the timeout callback already uses functional updates.

⏱️ Estimated Review Time: 5-15 minutes