Skip to content

excel support needs maintenance #1450

Closed

Description

@wltrimbl

validate_metadata looks like it uses the openpyxl library for xlsx and xlrd for older xls formatted spreadsheets. This is not the case. In fact, the MG-RAST openpyxl parser never works, and xlsx files are read by xlrd as a fallback.

An update to xlrd in December 2020 dropped support for the newer xlsx format
https://xlrd.readthedocs.io/en/latest/changes.html
and that broke all the validate_metadata tests.

PR #1449 pins the version of xlrd to 1.2.0 to prevent xlsx support from breaking immediately, but the code to handle xlsx needs to be fixed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions