Open
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change adds support for Bun and removes the need for the glob package.
Additionally, we currently install Glob as a sub-dependency, which means we don't have control over the version installed.
I did some testing, and newer versions of glob break our build. So, if we end up updating one of the packages that has Glob as a sub-dependency, and they have updated Glob, we may encounter issues. Then we end up with the problem that our build might break. Given that we don't directly need glob, I think it is a safer move to just use a Node Api instead of adding glob to the package.json.
One advantage of having support for Bun is that Windows users don't need a separate build command.
This means something like
bun run buildandbun cleanwill work on Windows.