Skip to content

Conversation

@colbyprior
Copy link
Contributor

Just a small thing. I ran into some issues installing this package in AWS user-data because of the utf-8 encoding in README.rst.

@gtback gtback self-assigned this Jul 5, 2018
@gtback
Copy link
Contributor

gtback commented Jul 5, 2018

Thanks, @colbyprior ! I was confused at first, thinking "where is the non-ASCII text in the README?" before realizing it's the character. There are a couple build failures, some of which are due to encoding not working on Python 2, and others just because of some other legacy stuff (unrelated to this change) that needs to be cleaned up.

I'll work on getting this all cleaned up and then merge this in! Thanks again.

@gtback gtback merged commit 109d451 into MAECProject:master Jul 5, 2018
@gtback
Copy link
Contributor

gtback commented Jul 5, 2018

I merged this via the command line. All the tests should pass in master.

@gtback gtback added this to the 4.1.0.14 milestone Jul 5, 2018
@colbyprior
Copy link
Contributor Author

Awesome. Thanks for the quick turnaround and fixing up the Python 2 test as-well.

@gtback
Copy link
Contributor

gtback commented Jul 10, 2018

Thanks for the contribution, @colbyprior !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants