Repository navigation
Let fuzz scripts set a VFS chunk size and flag all-zero salts - #52
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 3 3
Branches 3 3
=========================================
Hits 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
upstream/zero-salt-fuzz-chunk-size
branch
from
November 7, 2026 09:15
7d7c16b to
b2d0eec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzz VFS answered every file control with
SQLITE_NOTFOUND, so it never grew a file onSQLITE_FCNTL_SIZE_HINTand the salt oracle never saw the all-zero salt SQLCipher 4.20.0 gives a new database whose file was preallocated before page 1 was written. The VFS now keeps a chunk size per handle and grows and truncates to it the way the unix VFS does, and a new script op sets one. The salt oracle also aborts on an all-zero salt outright, so one database is enough to catch it, and it skips a page 1 the codec never wrote, which a preallocated chunk can leave behind after a failed write.The fix is sqlcipher/sqlcipher#633, still open against
prerelease. Like the sqlcipher#623 entry, a known-defect entry keeps the op off every line butprerelease, so PR fuzzing on the release never meets the crash and batch fuzzing onprereleasereports it until #633 merges. The entry goes away once a release carries the fix.