Repository navigation
Check that new databases draw distinct nonzero salts on the prerelease leg - #51
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 3 3
Branches 3 3
=========================================
Hits 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLCipher 4.20.0 gives a new database an all-zero salt when the VFS grows the file on
SQLITE_FCNTL_SIZE_HINTbefore page 1 is written. It reads the salt back from the first 16 bytes of the file and draws a random one only when that read fails, and a preallocated file reads back as zeros.opfs-sahpooldoes this for every new database, and the unix VFS does it once a chunk size is set. The sahpool tests here check rows, integrity and wrong keys, so none of them noticed.The sahpool tests now create two databases under one key and check that their salts are nonzero and differ, and the native interop program does the same on the unix VFS with a 64 KiB chunk size. The fix is sqlcipher/sqlcipher#633, still open against
prerelease, so both checks run only on theprereleaseleg. The release,nextandbetacarry the same code and keep the checks ignored until each of them carries a fix.