Generic triple pattern elements #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging in latest changes from origin
…oes not throw UnsupportedOperationException anymore
… represent elements of triple patterns; plus a generic factory for possible TriplePatternElement objects
… now partially generic (API-independent) and has been moved to separate parser classes
… TriplePatternElement interface for subject, predicate, and object.
…rnElement interface
…tternElement interface
Contributor
|
Is this to reconcile Sesame, Jena and any other API? |
Contributor
Author
|
Exactly. This PR is to separate out everything that is generic and API independent. This separation is meant to avoid code duplication in the API dependent code paths. For instance, note that the new class |
mielvds
pushed a commit
that referenced
this pull request
Dec 28, 2015
Generic triple pattern elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a generic, API-independent interface to represent elements of triple patterns, and refactors the existing code base to use this interface (which is called
TriplePatternElement). This refactoring is another step towards making an implementation of additional backends more easy; in particular, it helps to avoid code duplication for such implementations.