LibWeb/CSS: Implement the :heading/:heading() pseudo-class
#5830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming `:heading()` pseudo-class takes multiple comma-separated An+Bs. Also rename this field as the `:nth-[last-]child()` pseudo-classes are only a subset of the users.
Not everything we want to match is an "nth element". Also moved its serialization function's implementation out of the header while I was at it.
Corresponds to part of whatwg/html@65dc095
Corresponds to part of whatwg/html@65dc095
AtkinsSJ
force-pushed
the
heading-pseudo-class
branch
from
e9ba16c to
ccf1c19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just got added to the spec and has 308 juicy WPT subtests associated with it, which we now pass. 🎉