Repository navigation
feat(serialization)!: migrate from YamlDotnet to System.Text.Json - #125
Merged
Merged
Conversation
BREAKING CHANGE: Changes how AsyncApiAny works, removing most of the primitives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving away from YamlDotnet to System.Text.Json.
This will move us slightly further into the space of getting rid of JsonSchema all together, as there is a library that handles that.
The main reason for this being a breaking change is the removal of the
Anyprimitives.So instead of
new AsyncApiInteger(420)its nownew AsyncApiAny(420)as JsonNode has implicit conversions to most primitives.Im still not SUPER happy with the reading side of that though and will have to come up with something...
BREAKING CHANGE: Changes how AsyncApiAny works, removing most of the primitives.