Skip to content

AsyncAPI Schema object deserializer is missing some properties #122

Closed

Description

@crudbee

Describe the bug

Schema deserializer AsyncApiSchemaDeserializer.cs is missing some fixed fields compared to the AsyncAPI specification.

In particular:

patternProperties 
additionalItems 
propertyNames

Additional context

Similar PR's touching the same code #120 and #121

Activity

  1. github-actions commented on Jul 31, 2023

    @github-actions

    Welcome to AsyncAPI.NET. Thank you for reporting your first issue. Please check out our contributors guide.

  2. VisualBean commented on Jul 31, 2023

    @VisualBean
    Contributor

    additionalItems and items looks to be the same property, but according to spec 2.6 we should support both.
    https://json-schema.org/understanding-json-schema/reference/array.html
    https://www.asyncapi.com/docs/reference/specification/v2.6.0

    It also looks like its another one of those 'bool' or 'object' types of things.

    For the others as a reference for later
    https://json-schema.org/understanding-json-schema/reference/object.html#pattern-properties
    https://json-schema.org/understanding-json-schema/reference/object.html#property-names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions