This repository was archived by the owner on May 6, 2024. It is now read-only.
G4DarkBreM update and EaT-related Patches - #99
Merged
Conversation
tomeichlersmith
force-pushed
the
g4db-z-axis
branch
from
August 17, 2023 16:11
2e93ef0 to
8a5d3c7
Compare
very small bug only noticeable when investigating the enriched nuclear weight distribution in depth
was rebasing too quickly and didn't even stop to check if it compiled
tomeichlersmith
force-pushed
the
g4db-z-axis
branch
from
August 18, 2023 13:35
2c0c519 to
9f1a7a3
Compare
EinarElen
approved these changes
Aug 18, 2023
EinarElen
left a comment
Contributor
There was a problem hiding this comment.
Extremely minor comment comment aside, this looks reasonable to me. Only thing would be the default -1 value which could cause some issues if someone isn't reading the docs and tries to do something like taking the average Z of all event headers but I can't think of a better option since it has to be stored.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a few disparate patches related to my work studying the signal in the Ecal-as-Target analysis. They are relatively small changes that I have been using for several months and so I think it is fair to merge them in.
-1if the dark brem did not occur. This is very helpful for analysis of a signal sample to make sure the distribution of elements on-which the dark brem occurred makes sense.