This repository was archived by the owner on May 6, 2024. It is now read-only.
Framework bump rm event def - #111
Merged
Merged
Conversation
we /could/ rework this generator to use the new EventFile syntax (requiring deletion to close rather than a specific close method), but this generator has gone unused for so long I don't think it would run even with this patch. Besides, the updated full re-simulation infrastructure allows users to effectively re-sim from the ECal _perfectly_ so this running mode is already covered.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LDMX-Software/ldmx-sw#1251 for context.
Refactoring of the dictionary building infrastructure removed the
EventDef.hheader. This PR just removes that header and includes the specific event objects needed for the processors instead.In addition, I remove the
RootSimFromEcalSPgenerator for the following reasons. In general, I think it would be better to start from scratch, perhaps with a modification to the ReSimulator rather than using a generator with the plain simulator.EventFile::closefunction which has been removed from Framework in favor of a close-on-destruct method.