Skip to content
This repository was archived by the owner on Jul 31, 2022. It is now read-only.

Optimize MODLOAD (removed WATCHLOAD) and Add CACHELOAD. #107

Merged
Katsute merged 14 commits into from
Oct 20, 2020
Merged

Optimize MODLOAD (removed WATCHLOAD) and Add CACHELOAD. #107

Katsute merged 14 commits into from
Oct 20, 2020

Conversation

@Katsute
Copy link
Member

@Katsute Katsute commented Oct 18, 2020 •
edited
Loading

Prerequisites

If all checks are not passed then the pull request will be closed.

  • My code follows the style listed in CONTRIBUTING.
  • I have checked that no other similar pull requests already exists.
  • Build compiles.
  • Build runs without exceptions.
  • I have added/modified documentation (if applicable).
  • I have added/modified test cases.

Changes Made

List changes made and/or relevant issues. Please keep changed in reverse chronological order (newest at top).

@Katsute Katsute added documentation Improvements or additions to the documentation experimental An experimental feature feature request Request a feature optimization Optimizations labels Oct 18, 2020
@Katsute Katsute added this to the 4.0.0 milestone Oct 18, 2020
@Katsute Katsute self-assigned this Oct 18, 2020
@Katsute Katsute changed the title start work on watchload removal Optimize MODLOAD (was WATCHLOAD) and Add CACHELOAD. Oct 18, 2020
@Katsute Katsute changed the title Optimize MODLOAD (was WATCHLOAD) and Add CACHELOAD. Optimize MODLOAD (removed WATCHLOAD) and Add CACHELOAD. Oct 18, 2020
@Katsute Katsute marked this pull request as ready for review October 19, 2020 02:58
@Katsute
Copy link
Member Author

Katsute commented Oct 19, 2020

Todo: Add one more additional test to make sure that updating a cached file doesn't update a irrelevant cached file.

@Katsute
Copy link
Member Author

Katsute commented Oct 19, 2020

CacheAdapter should keep a variable for the closest expiry, then use this to determine when to check all files to clear and set the closest expiry from this.

@Katsute Katsute merged commit be8d868 into main Oct 20, 2020
@Katsute Katsute deleted the watch&cache@4788a57 branch October 20, 2020 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@Katsute Katsute

Labels

documentation Improvements or additions to the documentation experimental An experimental feature feature request Request a feature optimization Optimizations

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

Replace WatchLoad Implement caching system

2 participants

@Katsute