Skip to content

feat: new PHP target for Guzzle #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erunion wants to merge 16 commits into from
Closed

feat: new PHP target for Guzzle #228

erunion wants to merge 16 commits into from

Conversation

@erunion
Copy link
Contributor

@erunion erunion commented Sep 8, 2021 •
edited
Loading

This finishes up the work that @robertoarruda started in #140 to add a new PHP target for Guzzle.

Differences between their PR and this one:

  • Resolved a mess of conflicts that happened with rfc: drop support for < Node 10 #204 getting merged in.
  • Composer configurations have been removed from travis.yml as they're unused.
  • Removed some unused/unimplemented options.
  • Fixed up all unit tests.
  • Manually tested every Guzzle-generated snippet to ensure that it runs.
    • Some tweaks had to be made to multipart and cookie handling as a result of this.

Resolves #132 (and also #140).

@CLAassistant
Copy link

CLAassistant commented Sep 8, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ erunion
❌ robertoarruda
You have signed the CLA already but the status is still pending? Let us recheck it.

@erunion erunion closed this Apr 29, 2022
@erunion erunion deleted the feat/guzzle-target branch April 29, 2022 21:30
@erunion erunion mentioned this pull request Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHP Guzzle generator

3 participants

@erunion @CLAassistant @robertoarruda