rfc: drop support for < Node 10 #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reynolek
approved these changes
Apr 5, 2021
Contributor
reynolek
left a comment
reynolek
left a comment
There was a problem hiding this comment.
Thanks @erunion -- The change looks good. I am thinking of making this the v2 release so that people arent forced to upgrade to node 10 (although they really should be at least node 10!).
I want to do 1 more minor release with some changes that have been merged, and then I will merge this and release v2
Contributor
|
We will also need to remove a Node 8 build check in travis. |
|
|
Contributor
|
I resolved a conflict after merging another one of your PRs. |
Contributor
Author
|
@reynolek awesome ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current earliest version of Node that HTTPSnippet targets is Node 4 which was EOL'd in 2018. Probably time to cut it loose.
enginesrequirement to be >=10.url.parsewas deprecated in Node 11, andurlObjis populated with that.urldependency all together since it's just being used forurl.parseandurl.format. The new URL API should be able to be adequate.mochaandstandardto their latest versions now that we're no longer blocked by the node@4 requirement.pinkie-promisedependency as it's not used anywhere anymore.