Skip to content

Encode to JSON body for js-fetch target #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
develohpanda merged 1 commit into from
Sep 28, 2020
Merged

Encode to JSON body for js-fetch target #179

develohpanda merged 1 commit into from
Sep 28, 2020

Conversation

@jgiovaresco
Copy link
Contributor

@jgiovaresco jgiovaresco commented Sep 18, 2020

Closes #158

@jgiovaresco
Copy link
Contributor Author

jgiovaresco commented Sep 28, 2020

@develohpanda @reynolek I'm wondering if you have seen the PR 😅
You are the 2 last guys I've seen working on the project, but maybe I should ping someone else ? or maybe I just need to wait 😅

develohpanda
develohpanda approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@develohpanda develohpanda changed the title fix: stringify JSON body Encode to JSON body for js-fetch target Sep 28, 2020
@develohpanda develohpanda merged commit e2fa910 into Kong:master Sep 28, 2020
This was referenced Sep 28, 2020
Closed
Closed
@jgiovaresco jgiovaresco deleted the fix/158-stringify-fetch-json-post-body branch September 29, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@develohpanda develohpanda develohpanda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fetch 'application/json' POST body should be stringified

2 participants

@jgiovaresco @develohpanda