Fix JSON body for fetch #145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
$ sudo apt-get install -qq --yes python3 php5-curl php5-cli
210E: Unable to locate package php5-curl
211E: Package 'php5-cli' has no installation candidateLine 10 in c780dad Looks like the same error is still present in the installation of php5-cli, which is why tests are failing.
|
|
@darrenjennings would you mind running this again if the CI problem is resolved by now? |
Contributor
|
@sebastianhaas thanks for the note, this was due to #146, which is now fixed. Rerunning and will look shortly |
Contributor
|
@pizzafox would you mind rebasing onto master so CI will run the tests? |
Contributor
|
It looks like the test fixtures for |
* chore(travis) php 5 to 7 * chore(docker) add docker env
Contributor
Author
|
This broke a bunch of tests (that are flawed right now) that are looking for a JSON object rather than the string version to be the body. |
Contributor
|
Closing this PR in favor of #179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fetch API will convert the
bodyparameter to a string before sending the request. For bodies that are JSON, the JSON object will get converted to a string and become[object Object].This uses
JSON.stringify()to convert the object into a JSON string before sending the request.