Skip to content

Add r target #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenjennings merged 8 commits into from
Oct 25, 2019
Merged

Add r target #131

darrenjennings merged 8 commits into from
Oct 25, 2019

Conversation

@gabrielakoreeda
Copy link
Contributor

@gabrielakoreeda gabrielakoreeda commented Mar 30, 2019

Added a r language target using the library httr.

@wilder wilder mentioned this pull request Mar 31, 2019
Closed
@darrenjennings
Copy link
Contributor

darrenjennings commented Apr 26, 2019

@gabrielakoreeda thank you for this contribution! Our test suite on master is now stable. Can you add the output fixtures, fix and linting errors and get the tests passing? npm test should guide you in what you need to do. Look to #128 for inspiration.

@darrenjennings
Copy link
Contributor

darrenjennings commented May 23, 2019

@gabrielakoreeda I see tests are now passing, is this ready to be reviewed?

@gabrielakoreeda
Copy link
Contributor Author

gabrielakoreeda commented May 23, 2019

Yes!

gschier
gschier reviewed May 28, 2019
View reviewed changes
gschier
gschier approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@gschier gschier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. You too @darrenjennings?

@MarcBT
Copy link

MarcBT commented Aug 9, 2019

Hi there, thanks for this addition 👍 !
Any chance to have it merged and released soon ?!
Thanks a lot

@chakpongchung
Copy link

chakpongchung commented Oct 24, 2019

Hi there, thanks for this addition 👍 !
Any chance to have it merged and released soon ?!
Thanks a lot

I need this feature very much now! please merge and release!

@darrenjennings darrenjennings merged commit 109b9c4 into Kong:master Oct 25, 2019
@wilder
Copy link

wilder commented Oct 25, 2019

Nice one, @gabrielakoreeda !

@chakpongchung
Copy link

chakpongchung commented Oct 26, 2019

how can we use it in postman now?

@darrenjennings
Copy link
Contributor

darrenjennings commented Oct 29, 2019

@chakpongchung this lib has been forked and maintained separately by postman, so you would need to request on their repo.

@chakpongchung chakpongchung mentioned this pull request Oct 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gschier gschier gschier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabrielakoreeda @darrenjennings @MarcBT @chakpongchung @wilder @gschier