fix: order by walker signature

clementvtrd · muchafm · clementvtrd · commit 0564d62b76ad · 2024-03-08T16:16:17.000+01:00
Co-authored-by: muchafm &lt;47305202+muchafm@users.noreply.github.com&gt;
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
diff --git a/phpstan.neon b/phpstan.neon
@@ -2,5 +2,3 @@ parameters:
     level: 5
     paths:
         - src
-includes:
-    - phpstan-baseline.neon
diff --git a/src/Knp/Component/Pager/Event/Subscriber/Sortable/Doctrine/ORM/Query/OrderByWalker.php b/src/Knp/Component/Pager/Event/Subscriber/Sortable/Doctrine/ORM/Query/OrderByWalker.php
@@ -34,7 +34,7 @@ class OrderByWalker extends TreeWalkerAdapter
      * Walks down a SelectStatement AST node, modifying it to
      * sort the query like requested by url
      */
-    public function walkSelectStatement(SelectStatement $AST): string
+    public function walkSelectStatement(SelectStatement $AST): void
     {
         $query = $this->_getQuery();
         $fields = (array)$query->getHint(self::HINT_PAGINATOR_SORT_FIELD);
@@ -90,7 +90,5 @@ public function walkSelectStatement(SelectStatement $AST): string
                 $AST->orderByClause = new OrderByClause([$orderByItem]);
             }
         }
-
-        return '';
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ class OrderByWalker extends TreeWalkerAdapter`
`34`	`34`	`* Walks down a SelectStatement AST node, modifying it to`
`35`	`35`	`* sort the query like requested by url`
`36`	`36`	`*/`
`37`		`- public function walkSelectStatement(SelectStatement $AST): string`
	`37`	`+ public function walkSelectStatement(SelectStatement $AST): void`
`38`	`38`	`{`
`39`	`39`	`$query = $this->_getQuery();`
`40`	`40`	`$fields = (array)$query->getHint(self::HINT_PAGINATOR_SORT_FIELD);`
`@@ -90,7 +90,5 @@ public function walkSelectStatement(SelectStatement $AST): string`
`90`	`90`	`$AST->orderByClause = new OrderByClause([$orderByItem]);`
`91`	`91`	`}`
`92`	`92`	`}`
`93`		`-`
`94`		`- return '';`
`95`	`93`	`}`
`96`	`94`	`}`