Skip to content

fix: add missing files to SDist#171

Merged
Kludex merged 2 commits intoKludex:masterfrom
henryiii:henryiii/fix/sdist
Oct 27, 2024
Merged

fix: add missing files to SDist#171
Kludex merged 2 commits intoKludex:masterfrom
henryiii:henryiii/fix/sdist

Conversation

@henryiii
Copy link
Contributor

@henryiii henryiii commented Oct 24, 2024 •
edited
Loading

Quick fix for missing files in SDist, which also are missing from the wheel if you build the wheel from the SDist. But not if you build directly, which is why tests were passing. See #168.

$ uvx check-dist
SDist does not match git

SDist only:


Git only:
  docs/CNAME
  docs/api.md
  docs/changelog.md
  docs/index.md
  fuzz/README.md
  fuzz/corpus/fuzz_decoders/fuzz_decoders
  fuzz/corpus/fuzz_form/fuzz_form
  fuzz/corpus/fuzz_options_header/fuzz_options_header
  fuzz/fuzz_decoders.py
  fuzz/fuzz_form.py
  fuzz/fuzz_options_header.py
  fuzz/helpers.py
  mkdocs.yml
  scripts/README.md
  scripts/check
  scripts/lint
  scripts/rename
  scripts/setup
  scripts/test
  uv.lock

That looks pretty safe now.

@defnull
Copy link
Contributor

defnull commented Oct 24, 2024

Can you remove the "_python_multipart.pth", "_python_multipart_loader.py" part?

@henryiii henryiii mentioned this pull request Oct 24, 2024
Merged
@henryiii
Copy link
Contributor Author

henryiii commented Oct 24, 2024 •
edited
Loading

Yes, sure. Completely forgot about this, most of the time I use hatching's .gitignore based filtering instead of a manual list. The manual list is fine - as long as it's checked (see #172)!

@henryiii
fix: add missing files to SDist
f370484 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@musicinmybrain
Copy link

musicinmybrain commented Oct 26, 2024

This seems to work.

I wanted to verify that this doesn’t rely on building wheels with hatch build in particular, so I also tested this in a git checkout with python3 -m build and confirmed that the compatibility multipart/ package is still included in the wheel.

@Kludex Kludex merged commit c06830d into Kludex:master Oct 27, 2024
@mnovitsk mnovitsk mentioned this pull request Oct 29, 2024
Closed
@simonw simonw mentioned this pull request Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kludex Kludex Kludex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@henryiii @defnull @musicinmybrain @Kludex