Closed
Conversation
Also remove unused py_lib_dir.
These are set by the internal CMake ExternalProject.
This works with current scikit-build (0.8.1) even though the CMake variable will also work in future versions of scikit-build.
jcfr
reviewed
Jan 24, 2019
| py_exe, py_ver, py_inc_dir, py_lib = get_python_info() | ||
| build_type = 'Release' | ||
| source_path = "%s/%s-source" % (STANDALONE_DIR, PROJECT_NAME) | ||
| build_path = "%s/%s-osx_%s" % (ROOT_DIR, PROJECT_NAME, py_ver) |
Collaborator
There was a problem hiding this comment.
Similarly to what is done on manylinux (see here), the build process may be speed up by re-using the build tree.
Contributor
Author
There was a problem hiding this comment.
I also noted these todos:
Collaborator
|
@maekclena Could you check if this PR as well as #32 should be closed ? |
Contributor
Contributor
Author
|
@maekclena thanks so much for your help on this. This will help us add CC: @fbudin69500 |
Closed
Collaborator
|
Closing. This was superseded by #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.