Skip to content

Nadro/adhoc/zk codemirror#11617

Open
nadr0 wants to merge 11 commits into
mainfrom
nadro/adhoc/zk-codemirror
Open

Nadro/adhoc/zk codemirror#11617
nadr0 wants to merge 11 commits into
mainfrom
nadro/adhoc/zk-codemirror

Conversation

@nadr0
Copy link
Copy Markdown
Contributor

@nadr0 nadr0 commented May 12, 2026

Issue

ZK hot writes to disk and by passes code mirror

Implementation

  • allow openEditor to run on the result of ZK
  • allow openEditor to have in memory file of empty string if the disk read says "no file found"
  • call updateCodeEditor for the in memory editor which will schedule the write to disk and go through the proper code mirror workflow

@nadr0 nadr0 requested a review from a team as a code owner May 12, 2026 20:25
@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: modeling-app.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

Comment thread src/lang/KclManager.ts
resolve(text)
})
.catch((err) => {
if (err.message.includes('ENOENT')) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file does not exist on disk, this is an in memory buffer, don't crash the read!

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modeling-app Ready Ready Preview, Comment May 14, 2026 8:00pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants