Skip to content

Backport bounded minimatch expansion without changing the matcher API - #2

Merged
KirilsTurkins merged 1 commit into
developmentfrom
fix/runtime-minimatch-bounds-20261105
Nov 5, 2026
Merged

KirilsTurkins merged 1 commit into
developmentfrom
fix/runtime-minimatch-bounds-20261105

Conversation

@KirilsTurkins

Copy link
Copy Markdown
Owner

The setup-python action uses @actions/glob, which calls the minimatch 10 matchOne API. Upgrading that dependency to minimatch 11 breaks recursive matching. Retain minimatch 10.2.5 and apply the reviewed upstream expansion-bound fix to its CommonJS and ESM entry points, then rebuild the action bundles.

The deterministic source archive preserves the upstream package identity, dependency graph, license and unchanged files. An installed-source verifier checks the original and repaired archives, recipe, owner and lock identities, every v10 lock copy, package metadata, license and both installed source postimages before the build. Focused tests cover expansion bounds, the existing matchOne API, and refusal of duplicate lock entries or changed source/archive bytes. Upstream minimatch 10.2.5 is still an affected release; this is a maintained source repair, not a new upstream release or an advisory exception.

On Windows with Node 24.19.0/npm 11.17.0, clean locked installation, npm ls, the existing deepmerge verifier, both action rebuilds and all 11 Jest suites / 249 tests passed. Fifteen real @actions/glob pattern scenarios matched the original action, and the two focused source tests passed. Linux hosted build and downstream independent scanner qualification are pending.

@KirilsTurkins

Copy link
Copy Markdown
Owner Author

The inherited upstream PR workflows queued over a thousand platform-matrix jobs and were canceled to free capacity for current development checks. This includes the generic e2e run that had started. Those canceled runs are not passing evidence. The inherited CodeQL workflow separately ended with startup_failure; GitHub exposes no job or log for that run, so its cause is not established.

The dedicated matcher source owner remains active on the exact PR source with only its diagnostic workflow added. It will check the locked install, both source verifiers, rebuilt runtime bundles, upstream tests and source-refusal controls, and retain the selected build evidence.

@KirilsTurkins

Copy link
Copy Markdown
Owner Author

The focused Linux owner passed on the exact candidate source with only its diagnostic workflow added: locked install, source verifiers, both bundle rebuild comparisons, 11 suites / 249 tests and the two matcher source controls passed. Artifact 13406518961 has SHA-256 62e0ab9584d507a4217d9d10ce03d3054babd1171c6b6abc0b1ef4fa7e7ee85d; all 11 ZIP entries passed CRC verification and the runtime bundles and source artifacts match the candidate identities.

The inherited CodeQL workflow reported startup failure before creating any job or log, so its cause is not established and it is not a pass. Inherited platform matrix copies were canceled to prioritize the focused owner and current development checks. Downstream scanner integration remains separate.

@KirilsTurkins
KirilsTurkins merged commit 164c4cb into development Nov 5, 2026
0 of 1015 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant