feat: add FIM support to KilocodeOpenrouterHandler #3492
Merged
+235
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
markijbema
force-pushed
the
feat/add-fim-support-to-kilocode-openrouter
branch
5 times, most recently
from
5187ec9 to
0cfe7ed
Compare
- Add supportsFim() method to check if model supports FIM (codestral models) - Add completeFim() method for non-streaming FIM completions - Add streamFim() method for streaming FIM completions - Reuse customRequestOptions() for header management (DRY principle) - Use DEFAULT_HEADERS for consistency with chat completions - Add comprehensive test coverage with 6 new test cases - Implementation follows the same pattern as KiloCode.ts for consistency All tests pass (14/14)
markijbema
force-pushed
the
feat/add-fim-support-to-kilocode-openrouter
branch
from
0cfe7ed to
6374a1c
Compare
markijbema
force-pushed
the
feat/add-fim-support-to-kilocode-openrouter
branch
from
b2903be to
e1f904b
Compare
Comment on lines
219
to
262
| it("completeFim makes request with correct parameters", async () => { | ||
| const handler = new KilocodeOpenrouterHandler({ | ||
| ...mockOptions, | ||
| kilocodeModel: "mistral/codestral-latest", | ||
| kilocodeOrganizationId: "test-org-id", | ||
| }) | ||
|
|
||
| const mockStream = new ReadableStream({ | ||
| start(controller) { | ||
| controller.enqueue( | ||
| new TextEncoder().encode('data: {"choices":[{"delta":{"content":"completed "}}]}\n'), | ||
| ) | ||
| controller.enqueue(new TextEncoder().encode('data: {"choices":[{"delta":{"content":"code"}}]}\n')) | ||
| controller.enqueue(new TextEncoder().encode("data: [DONE]\n")) | ||
| controller.close() | ||
| }, | ||
| }) | ||
|
|
||
| const mockResponse = { | ||
| ok: true, | ||
| body: mockStream, | ||
| } | ||
|
|
||
| global.fetch = vitest.fn().mockResolvedValue(mockResponse) | ||
|
|
||
| const result = await handler.completeFim("prefix code", "suffix code", "test-task-id") | ||
|
|
||
| expect(result).toBe("completed code") | ||
| expect(global.fetch).toHaveBeenCalledWith( | ||
| expect.any(URL), | ||
| expect.objectContaining({ | ||
| method: "POST", | ||
| headers: expect.objectContaining({ | ||
| "Content-Type": "application/json", | ||
| Accept: "application/json", | ||
| "x-api-key": "test-token", | ||
| Authorization: "Bearer test-token", | ||
| [X_KILOCODE_TASKID]: "test-task-id", | ||
| [X_KILOCODE_ORGANIZATIONID]: "test-org-id", | ||
| }), | ||
| body: expect.stringContaining('"stream":true'), | ||
| }), | ||
| ) | ||
| }) |
There was a problem hiding this comment.
delete test, I think?
EamonNerbonne
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests pass (14/14)
Context
Implementation
Screenshots
How to Test
Get in Touch