removed entity tmp table deletion from bq as needed for executin sql …#44
Merged
alessandro-rizzo-ki merged 2 commits intoJun 13, 2025
Merged
Conversation
…query outside of this context
owen-oclee-ki
approved these changes
Jun 13, 2025
owen-oclee-ki
left a comment
owen-oclee-ki
left a comment
There was a problem hiding this comment.
lgtm! is there any process we should follow to check they are indeed cleaned up automatically? or have we already verified this?
Author
I'm going to do some tests from the client to double check this 👍 |
Author
|
Tested that the ephemeral table is created with an expiry date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed bq table delete for temp tables which contain the entities requested for historical retrieval at https://github.com/Ki-Insurance/feast/blob/master/sdk/python/feast/infra/offline_stores/bigquery.py#L290
This is only a fallback as these temp tables are due to expire in 30m anyway as we can see here https://github.com/Ki-Insurance/feast/blob/master/sdk/python/feast/infra/offline_stores/bigquery.py#L711
We're trying to get the SQL query that feast uses to retrieve the historical features (PR at https://github.com/Ki-Insurance/feature-store-connector/pull/516) so that we can run it client-side in the feature store connector client.
Since the creation of this SQL query is wrapped in a context manager here https://github.com/Ki-Insurance/feast/blob/master/sdk/python/feast/infra/offline_stores/bigquery.py#L253 , when we execute the query client-side the table has been already removed.
This change removes the fallback (virtually no extra risk as they expire anyway and names are uuid unique) and allows us to use that temp table later on after the call to feast 'server' has completed.
There are some failing tests which have to do with registry validation, they seem unrelated and they currently fail on main. I'm tempted to merge anyway and fix at a later date.
