Skip to content

Drop doctrine/cache support (fixes #155, #188)#201

Merged
Kevinrob merged 2 commits into
masterfrom
copilot/fix-280a648e-066a-4eb6-a532-d6edddaf4860
Aug 3, 2025
Merged

Drop doctrine/cache support (fixes #155, #188)#201
Kevinrob merged 2 commits into
masterfrom
copilot/fix-280a648e-066a-4eb6-a532-d6edddaf4860

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Aug 1, 2025

This PR removes support for the deprecated doctrine/cache package as requested in issues #155 and #188. The doctrine/cache package is intended to be abandoned and this change modernizes the codebase to focus on current PSR cache standards.

Changes Made

Removed Dependencies

  • Removed doctrine/cache from require-dev dependencies
  • Removed doctrine/cache from the suggest section in composer.json
  • Removed "doctrine" from package keywords

Removed Code

  • Deleted src/Storage/DoctrineCacheStorage.php
  • Deleted src/Storage/CompressedDoctrineCacheStorage.php

Updated Tests

  • Removed all doctrine/cache test cases from PrivateCacheTest.php and PublicCacheTest.php
  • Tests now rely on modern PSR-6, PSR-16, Flysystem, and VolatileRuntimeStorage implementations
  • All remaining tests provide adequate coverage for cache functionality

Updated Documentation

  • Removed the entire "Doctrine/Cache" section with examples from README.md
  • Updated "Public and shared" example to use PSR-6 and Flysystem instead
  • Updated "Greedy caching" example to use Flysystem
  • Updated the built-in storage interfaces list to reflect current options

Migration Path

Users currently using doctrine/cache should migrate to one of the modern alternatives:

  • PSR-6 Cache: Use Psr6CacheStorage with any PSR-6 compatible cache pool
  • PSR-16 Simple Cache: Use Psr16CacheStorage with any PSR-16 compatible cache
  • Flysystem: Use FlysystemStorage for file-based caching
  • Laravel: Use LaravelCacheStorage for Laravel applications
  • WordPress: Use WordPressObjectCacheStorage for WordPress applications

Validation

  • All PHP files pass syntax validation
  • composer.json validates successfully
  • Verified doctrine/cache is no longer installed as a dependency
  • All remaining storage classes work correctly
  • No doctrine references remain in the codebase

This change ensures the library stays current with modern PHP caching standards while removing dependency on deprecated packages.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/kylekatarnls/update-helper/zipball/429be50660ed8a196e0798e5939760f168ec8ce9
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/q5D88n /usr/bin/composer install (http block)
  • https://api.github.com/repos/php-fig/http-message/zipball/402d35bcb92c70c026d1a6a9883f06b2ead23d71
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/ZuYk88 /usr/bin/composer install --no-dev (http block)
  • https://api.github.com/repos/ralouphie/getallheaders/zipball/120b605dfeb996808c31b6477290a714d356e822
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/av2PIo /usr/bin/composer install --no-dev (http block)
  • https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/av2PIo /usr/bin/composer install --no-dev (http block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: Kevinrob <4509277+Kevinrob@users.noreply.github.com>
Copilot AI changed the title [WIP] Drop doctrine/cache support and update tests Drop doctrine/cache support (fixes #155, #188) Aug 1, 2025
Copilot AI requested a review from Kevinrob August 1, 2025 10:28
@Kevinrob Kevinrob marked this pull request as ready for review August 1, 2025 15:48
@Kevinrob Kevinrob merged commit a63dfa7 into master Aug 3, 2025
16 checks passed
@Kevinrob Kevinrob deleted the copilot/fix-280a648e-066a-4eb6-a532-d6edddaf4860 branch August 3, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants