Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Conversation

@R4356th
Copy link
Contributor

@R4356th R4356th commented May 25, 2021

The whole Revision class has been hard deprecated and will be removed in 1.37. User::newFromId has been soft deprecated and will possibly be hard deprecated in 1.37. This replaces their usages with services.

@Kenny2github Kenny2github self-requested a review May 25, 2021 13:00
@Kenny2github Kenny2github added the prnr Pull request, needs review label May 25, 2021
Copy link
Owner

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of extraneous uses can be removed now.

@Kenny2github Kenny2github added prnw Pull request, needs work and removed prnr Pull request, needs review labels May 25, 2021
R4356th and others added 2 commits May 25, 2021 19:24
Co-authored-by: Kenny2github <kenny2minecraft@gmail.com>
Co-authored-by: Kenny2github <kenny2minecraft@gmail.com>
@R4356th
Copy link
Contributor Author

R4356th commented May 25, 2021

Whoops! Sorry for missing those.

@R4356th R4356th requested a review from Kenny2github May 25, 2021 13:25
@Kenny2github Kenny2github added prgtm Pull request, good to merge and removed prnw Pull request, needs work labels May 25, 2021
@Kenny2github Kenny2github merged commit 43ed2a8 into Kenny2github:master May 25, 2021
wmfgerrit pushed a commit to wikimedia/mediawiki-extensions-Report that referenced this pull request May 25, 2021
add translation for Turkish (#11)

From Kenny2github/Report#11

* add translation

* add special page alias

* Update Report.i18n.alias.php

Replaces usages of deprecated Revision::newFromId and User::newFromId (#10)

From Kenny2github/Report#10

* Replace deprecated use of Revision::newFromId

* Replace usages of deprecated User::newFromId

* Remove extraneous "use User;"

Co-authored-by: Ahmet <63475369+ahmetlii@users.noreply.github.com>

Co-authored-by: R4356thwiki <radman.siddiki@gmail.com>

Co-authored-by: Kenny2github <kenny2minecraft@gmail.com>

Change-Id: If59706ab83f11cdb41b44d1adc38a2cdec3ac2f6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

prgtm Pull request, good to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants