Skip to content

Avoid having to use sudo for running the tests.#962

Merged
rosbo merged 1 commit into
masterfrom
rm-sudo-need-for-tests
Feb 26, 2021
Merged

Avoid having to use sudo for running the tests.#962
rosbo merged 1 commit into
masterfrom
rm-sudo-need-for-tests

Conversation

@rosbo

@rosbo rosbo commented Feb 26, 2021

Copy link
Copy Markdown
Contributor

A test run creates files under the /tmp/python-build directory. The
owner of these files are the user assigned to your docker process.

Running rm -rf /tmp/python-build in the test script fails with:

rm: cannot remove '/tmp/python-build/working/logs/train_log/events.out.tfevents.1614297217.localhost': Permission denied
...

Because your user don't have the permissions to delete these files.

Updating the test script to delete these files inside the a docker
container to circumvent this problem.

A test run creates files under the /tmp/python-build directory. The
owner of these files are the user assigned to your docker process.

Running `rm -rf /tmp/python-build` in the test script fails with:

```
rm: cannot remove '/tmp/python-build/working/logs/train_log/events.out.tfevents.1614297217.localhost': Permission denied
...
```

Because your user don't have the permissions to delete these files.

Updating the `test` script to delete these files inside the a docker
container to circumvent this problem.
@rosbo rosbo requested a review from bovard February 26, 2021 00:14

@bovard bovard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosbo rosbo merged commit 7d96dee into master Feb 26, 2021
@rosbo rosbo deleted the rm-sudo-need-for-tests branch February 26, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants