Delete old tagged images from Jenkins GPU worker#776
Merged
Conversation
Contributor
|
Should we do the same on R side? |
Contributor
Author
|
Not necessary, |
Philmod
approved these changes
Apr 14, 2020
Contributor
I was thinking about the very improbable case that there is no python builds but a ton of R's. |
Contributor
Author
|
Quite improbable considering we automatically trigger builds for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPU Jenkins workers are ephemeral meaning they are recreated between each build.
GPU Jenkins workers are not, the GCP Jenkins plugin doesn't support GPU VMs well.
Every 2-3 weeks, the GPU builds would start failing because the disk has filled up.
We were already deleting dangling images (untagged). However, we were never deleting the old images with a tag (non-dangling). This meant that we kept the images from the last build for a given branch on the worker until the disk filled up causing failures.
The fix was to manually SSH to the GPU worker and run
docker system prune -a -fwhen it happened when a build failure cause by the GPU worker disk filling occured.With this PR, we won't have build anymore failing for this reason and we won't need to perform that manual SSH step.
BUG=129682568