Refactor to utils class

jbee37142 · jbee37142 · commit 2b9b4aa52baa · 2017-06-04T16:42:47.000+09:00
diff --git a/src/test/java/sort/SelectionSort.java b/src/test/java/sort/SelectionSort.java
@@ -1,6 +1,7 @@
 package sort;
 
 import org.junit.Test;
+import utils.Utils;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.junit.Assert.assertThat;
@@ -23,10 +24,6 @@ public void test() {
         int[] arr3 = {1};
         int[] sortedArr3 = {1};
         assertThat(solution(arr3), is(sortedArr3));
-
-        int[] arr = {1,2,3};
-        int[] chagedArr = {1,3,2};
-        assertThat(swapValue(arr, 1,2), is(chagedArr));
     }
 
     public int[] solution(int[] arr) {
@@ -41,15 +38,8 @@ public int[] solution(int[] arr) {
                     maxPos = k;
                 }
             }
-            result = swapValue(result, i, maxPos);
+            result = Utils.swapValue(result, i, maxPos);
         }
         return result;
     }
-
-    private int[] swapValue(int[] arr, int a, int b) {
-        int temp = arr[a];
-        arr[a] = arr[b];
-        arr[b] = temp;
-        return arr;
-    }
 }
diff --git a/src/test/java/utils/Utils.java b/src/test/java/utils/Utils.java
@@ -0,0 +1,28 @@
+package utils;
+
+import org.junit.Test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class Utils {
+
+    /*
+        TASK
+        swap util 분리
+     */
+
+    @Test
+    public void test() {
+        int[] arr = {1,2,3};
+        int[] chagedArr = {1,3,2};
+        assertThat(swapValue(arr, 1,2), is(chagedArr));
+    }
+
+    public static int[] swapValue(int[] arr, int a, int b) {
+        int temp = arr[a];
+        arr[a] = arr[b];
+        arr[b] = temp;
+        return arr;
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`package sort;`
`2`	`2`
`3`	`3`	`import org.junit.Test;`
	`4`	`+import utils.Utils;`
`4`	`5`
`5`	`6`	`import static org.hamcrest.CoreMatchers.is;`
`6`	`7`	`import static org.junit.Assert.assertThat;`
`@@ -23,10 +24,6 @@ public void test() {`
`23`	`24`	`int[] arr3 = {1};`
`24`	`25`	`int[] sortedArr3 = {1};`
`25`	`26`	`assertThat(solution(arr3), is(sortedArr3));`
`26`		`-`
`27`		`- int[] arr = {1,2,3};`
`28`		`- int[] chagedArr = {1,3,2};`
`29`		`- assertThat(swapValue(arr, 1,2), is(chagedArr));`
`30`	`27`	`}`
`31`	`28`
`32`	`29`	`public int[] solution(int[] arr) {`
`@@ -41,15 +38,8 @@ public int[] solution(int[] arr) {`
`41`	`38`	`maxPos = k;`
`42`	`39`	`}`
`43`	`40`	`}`
`44`		`- result = swapValue(result, i, maxPos);`
	`41`	`+ result = Utils.swapValue(result, i, maxPos);`
`45`	`42`	`}`
`46`	`43`	`return result;`
`47`	`44`	`}`
`48`		`-`
`49`		`- private int[] swapValue(int[] arr, int a, int b) {`
`50`		`- int temp = arr[a];`
`51`		`- arr[a] = arr[b];`
`52`		`- arr[b] = temp;`
`53`		`- return arr;`
`54`		`- }`
`55`	`45`	`}`