Skip to content

Update SpriteHelper type comparisons to use ClassIDType instead of string - #74

Merged
K0lb3 merged 3 commits into
K0lb3:masterfrom
yvsdrop:patch-2
Nov 16, 2021
Merged

K0lb3 merged 3 commits into
K0lb3:masterfrom
yvsdrop:patch-2

Conversation

@yvsdrop

@yvsdrop yvsdrop commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

After certain changes in the past, doing simple String comparison on the type attribute of objects will no longer work as expected - should be comparing against the ClassIDType enum instead. (or do obj.type.name == "string name")

yvsdrop and others added 2 commits November 16, 2021 13:32
…ring

After certain changes in the past, doing simple String comparison on the type attribute of objects will no longer work as expected - should be comparing against the ClassIDType enum instead. (or do obj.type.name == "string name")
@K0lb3

K0lb3 commented Nov 16, 2021

Copy link
Copy Markdown
Owner

You're right.
I forgot that it's so far implemented in such a bad way,
using ClassIDType itself is definitely better.

@K0lb3
K0lb3 merged commit af02fbd into K0lb3:master Nov 16, 2021
@yvsdrop
yvsdrop deleted the patch-2 branch November 17, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants