Skip to content

Fix ContainerHelper for .container retrieval - #200

Merged
K0lb3 merged 1 commit into
K0lb3:masterfrom
t-wy:fix_container
Sep 30, 2023
Merged

K0lb3 merged 1 commit into
K0lb3:masterfrom
t-wy:fix_container

Conversation

@t-wy

@t-wy t-wy commented Aug 9, 2023 •

Copy link
Copy Markdown
Contributor

This commit is aware of the difference between _container and container_ in old versions of SerializedFile.py for compatibility.

It should be matching the behavior of .container property in the previous versions, addressing the issue #199 in 1.10.2 returning None for the first two items below:

  • .container in ObjectReader.py: returning the container path of the asset the ObjectReader handles.
  • .container in Object.py: same as above.
  • .container in SerializedFile.py: returning the {container path: a corresponding asset} dictionary now handled by ContainerHelper (the legacy container_ attribute)

Resolves #199

This commit is aware of the difference between _container and container_ in old versions of SerializedFile.py for compatibility.
@K0lb3
K0lb3 merged commit 52ff053 into K0lb3:master Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContainerHelper does not look right that .container returns None

2 participants