Skip to content

Fix random ResourceReader file loading - #190

Merged
K0lb3 merged 1 commit into
K0lb3:masterfrom
RealSupremium:fix-resource-reader-randomness
Jul 18, 2023
Merged

K0lb3 merged 1 commit into
K0lb3:masterfrom
RealSupremium:fix-resource-reader-randomness

Conversation

@RealSupremium

Copy link
Copy Markdown
Contributor

You may not believe it (or you probably did already), but possible_names was actually a dictionary type before. The problem with that is you get these random numbers as keys, and the items inside go out of order.

image

@K0lb3

K0lb3 commented Jul 18, 2023

Copy link
Copy Markdown
Owner

It doesn't create a dict but a set.
The idea behind it is to prevent duplicates, which used to be relevant before using .lowercase for the lookup.
Now it's indeed not necessary to use a set anymore and a list would do, indeed.

@K0lb3
K0lb3 merged commit 8c2397a into K0lb3:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants