You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Final replace call in export_mesh causes wrong mesh name #66
The replace("NaN", "0") will cause 'NaN' in name be wrongly converted, too.
NaN is replaced with 0 because AssetStudio does so as well, see here.
I'm not sure why either, but considering that it gets way more reports about such issues, it's probably correct for whatever reason.
And it also seems to be useless since '{}'.format(float('nan')) == 'nan'.
Indeed, I just noticed that as well -.-'
Use '{:G}'.format(1e21) will gives us 1E21, so replace("e", "E") can be removed if we update the format str.
Activity
AutumnSun1996 commentedon Aug 2, 2021
The
replace("NaN", "0")will cause 'NaN' in name be wrongly converted, too.And it also seems to be useless since
'{}'.format(float('nan')) == 'nan'.Use
'{:G}'.format(1e21)will gives us1E21, soreplace("e", "E")can be removed if we update the format str.Still have to handle the "NAN". And, do we have to take "INF" and "-INF" into consider?
K0lb3 commentedon Oct 15, 2021
Sorry that I forgot to reply.
NaN is replaced with 0 because AssetStudio does so as well, see here.
I'm not sure why either, but considering that it gets way more reports about such issues, it's probably correct for whatever reason.
Indeed, I just noticed that as well -.-'
That seems to be the best solution.
resolves K0lb3#66