Merged
Conversation
Contributor
|
Would this work for Python 3.11 & 3.12 if it specifies fields only on these versions? |
Contributor
Author
|
I think so. The worse issue is having fewer fields, because then it will overwrite neighboring constants and corrupt them. Correct me if I'm wrong @cjdoris |
Contributor
Author
|
I think benchmark pr failing is unrelated (and likely due to a slightly older version of my fork). Looks ready for merge though @cjdoris (thanks for the quick help) |
Member
|
Thanks for the hotfix. I'll make a release later today. I'd be grateful if you could make an issue for the "proper" fix, linking to all the relevant discussion. Cheers. |
Member
|
Released. Hopefully that's the segfault gone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't the full solution from the discourse thread, but I would like to get a hotfix in ASAP to prevent further segfaults until we can get a future-compatible heap type solution in.
@cjdoris could you merge and release?