fix: patch changed behavior of setproperty! for modules#583
fix: patch changed behavior of setproperty! for modules#583cjdoris merged 15 commits intoJuliaPy:mainfrom
setproperty! for modules#583Conversation
test/Aqua.jl
Outdated
| @@ -2,5 +2,9 @@ | |||
| # The unbound_args test fails on methods with signature like foo(::Type{Tuple{Vararg{V}}}) where V | |||
There was a problem hiding this comment.
Unrelated but this is a real unbound_args. V is unbound in Tuple{Vararg{V}} because () is technically a subtype - in which case V has no definition.
Correct signature with bounded V would be Tuple{V,Vararg{V}}
|
FYI I'm ignoring some of the broken tests (only two; seem minor) temporarily since I see the |
|
The only remaining test error is from the julia_gc test. I think it's more likely this is due to Julia bugs since 1.11's parallel GC has some internal issues (e.g., JuliaLang/julia#56871, JuliaLang/julia#56759, JuliaLang/julia#56735). I'll turn off that test for 1.11 too, since it doesn't identify an issue with PythonCall.jl (if that's alright with you). We can look into it later once 1.11.3 comes out. |
|
@cjdoris we're getting errors in other PRs that require this behavior; do you think this could be merged when you get a chance? |
|
Thanks - I spent some time understanding the various test changes and made some tweaks/fixes in the process. Will make a release. |
|
Awesome, thanks! |
2 participants
This fixes the breaking change introduced by Julia 1.11: JuliaLang/julia#54678. Fixes #582. See JuliaLang/julia#56933 for more discussion.
The fix is pretty simple - we just automatically call
globalon variables that are undefined. This means that the syntaxwill continue to function.
@cjdoris could you please take a look and merge? Since Julia 1.11 is out now I think we should get this fix in relatively quickly since a lot of the docs and tutorials rely on this behavior working.
Edit: also fixed some of the other tests (see discussion below)