This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Resolve compat issues for m1 macs #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilia <i.ilmer@icloud.com>
Member
|
Thanks for spotting the problems and open this PR. I just run the tests, and there are problems apparently due to requirements from TaylorModels.jl with Julia version 1.5 (see https://github.com/JuliaIntervals/ValidatedNumerics.jl/actions/runs/4078312446/jobs/7046642429#step:5:29). Could you increase the Julia version required to Julia 1.6, as well as the tests, which should not consider Julia v1.5? We should also tag a new minor version? |
Signed-off-by: Ilia <i.ilmer@icloud.com>
Contributor
Author
|
@lbenet I added the versions to CI.yml and Project.toml, should work now. |
lbenet
approved these changes
Feb 4, 2023
Member
lbenet
left a comment
lbenet
left a comment
There was a problem hiding this comment.
LGTM! I'll go ahead and merge this, and also register the new version. Thanks a lot!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves to #293