-
Notifications
You must be signed in to change notification settings - Fork 17
Rewrite the package to use Symbolics and ReversePropagation #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5c691c1
0a0714f
db996d4
7409720
ffee1fd
15283da
35a2876
2844f7c
9736773
d867bf0
aae4823
78c030b
b80c90b
c350781
3366fb4
99c8e37
89e95df
f3172fa
bebc669
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,11 +2,4 @@ | |
| *.jl.*.cov | ||
| *.jl.mem | ||
| docs/build/ | ||
|
|
||
| *.DS_Store | ||
|
|
||
| coverage/ | ||
|
|
||
| .vscode | ||
|
|
||
| Manifest.toml | ||
| Manifest.toml | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,25 @@ | ||
| name = "IntervalConstraintProgramming" | ||
| uuid = "138f1668-1576-5ad7-91b9-7425abbf3153" | ||
| version = "0.13" | ||
| version = "0.14.0" | ||
|
|
||
| [deps] | ||
| IntervalArithmetic = "d1acc4aa-44c8-5952-acd4-ba5d80a2a253" | ||
| IntervalBoxes = "43d83c95-ebbb-40ec-8188-24586a1458ed" | ||
| IntervalContractors = "15111844-de3b-5229-b4ba-526f2f385dc9" | ||
| MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09" | ||
| Requires = "ae029012-a4dd-5104-9daa-d747884805df" | ||
| ReversePropagation = "527681c1-8309-4d3f-8790-caf822a419ba" | ||
| StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" | ||
| Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7" | ||
|
|
||
| [compat] | ||
| IntervalArithmetic = "0.16, 0.17, 0.18, 0.19, 0.20" | ||
| IntervalContractors = "0.4" | ||
| MacroTools = "0.4, 0.5" | ||
| Requires = "0.5, 1" | ||
| julia = "1.3" | ||
| IntervalArithmetic = "0.22.12" | ||
| IntervalContractors = "0.5" | ||
| ReversePropagation = "0.3" | ||
| Symbolics = "5, 6" | ||
| julia = "1" | ||
|
Comment on lines
-16
to
+18
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Symbolics v5 already required Julia v1.6, so widening the lower bound from v1.3 to v1.0 seems strange. Maybe you intended to use a higher version?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Won't that get resolved automatically?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. True, just tried it: (v1.1) pkg> add IntervalConstraintProgramming
[...]
Installed IntervalConstraintProgramming ─ v0.12.0
[...]But I still find it misleading when you look at the Project file to know which version you need at least. Then I would rather omit the |
||
|
|
||
| [extras] | ||
| Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7" | ||
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
|
||
| [targets] | ||
| test = ["Test", "Symbolics"] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| julia 1.0 | ||
| ModelingToolkit | ||
| IntervalArithmetic 0.15 | ||
| IntervalRootFinding 0.4 | ||
| IntervalContractors 0.3 | ||
| MacroTools 0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not recommend removing the tests on older Julia versions and only testing on v1.10. It is very easy to introduce changes that break old versions unnoticed (I saw it happening many times), particularly because you presumably do not use them for development anymore. If v1.10 is the lowest supported version, that should be reflected in Project.toml (see the other comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to just set the lower bound as 1.10 since that's the new LTS version, right?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally reasonable.
But note that v1.6-v1.9 would still be installing the current release. So if it broke, that would leave the package in a broken state for these Julia versions. (You could retroactively fix the entry in the registry to raise the Julia version in that case.)