Skip to content

Conversation

@lucaferranti
Copy link
Member

Removed tests with DynamicPolynomials, and updated Project.toml. Should fix #176

@lucaferranti
Copy link
Member Author

The test causing problems is

    a = 3
    S4 = @constraint x^2 + y^2 - $a <= 0
    paving = pave(S4, X)

with error UndefVarError: a not defined . The failure is only on nightly, it works on 1.4 (and on 1.5, tested on my machine). What should we do with this?

@lucaferranti lucaferranti force-pushed the lferrant/remove-dynamicPolynomials branch from a9200c0 to 83e1a0a Compare March 3, 2021 17:06
@lucaferranti
Copy link
Member Author

@dpsanders allowing failure on nightly (the other packages in juliaintervals allow it too) it seems to work. I think this is starting to look ready, what do you think?

@dpsanders
Copy link
Member

Rather than just removing those tests can they be replaced with tests using ModelingToolkit variables? Or are. There similar tests already?

@lucaferranti
Copy link
Member Author

yes, there seem to be a couple of tests using MTK with Separator here and with Contractor here

@dpsanders dpsanders merged commit a3827dc into JuliaIntervals:master Mar 4, 2021
@dpsanders
Copy link
Member

Thanks!

@lucaferranti lucaferranti deleted the lferrant/remove-dynamicPolynomials branch March 5, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove use of DynamicPolynomials

2 participants