$ to `` and update docs packages #158
Conversation
| git-tree-sha1 = "88bb0edb352b16608036faadcc071adda068582a" | ||
| uuid = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae" | ||
| version = "0.7.0" | ||
| version = "0.8.1" |
There was a problem hiding this comment.
Are you sure that these are the minimum possible versions? E.g. 0.8.0 doesn't work? Probably this should just be 0.8
There was a problem hiding this comment.
I don't think the Manifest.toml file should actually be included at all?
There was a problem hiding this comment.
I'm not completely sure about this:
- I think the Manifest.toml is useful in the
docssuch that travis/GitHub Actions use the same version every time to generate the docs. Otherwise you need to provide upper bounds to be sure that it doesn't break when Documenter updates.
Users of a package normally don't generate the docs locally. (At least I don't 😄 ) Therefore I think the versions used there are not breaking anything for the user.
The root Manifest.toml shouldn't be included I think because there it should use the highest version possible if allowed by the specified[Compat]section and also a strict version shouldn't be forced as long as the package works the version for subpackages is often not important.
There was a problem hiding this comment.
OK thanks for the comments. Shall I just go ahead and merge this then? Or will the docs be built during this PR?
There was a problem hiding this comment.
Unfortunately I think you need to merge this to see the actual output.
I'm not sure why travis is not running for this package. Do you only run it on master?
There was a problem hiding this comment.
Seems like for the other PRs travis is running 😕
There was a problem hiding this comment.
I expect that's out of date too.
There was a problem hiding this comment.
Maybe you get some useful information on travis.org?
There was a problem hiding this comment.
It did run:
https://travis-ci.org/github/JuliaIntervals/IntervalConstraintProgramming.jl/builds/670175731
Don't know why that wasn't picked up.
|
Thanks a lot for this! |
|
Travis ran but the docs look the same... |
|
There are some errors: https://travis-ci.org/github/JuliaIntervals/IntervalConstraintProgramming.jl/jobs/670175738#L337-L342 |
|
Okay it seems to be running on PR and there it fails because it normally only deploys on master. |
|
Btw you can use |
|
I don't see the documentation job running on Travis.
…On Thu, Apr 2, 2020 at 12:34 PM Ole Kröger ***@***.***> wrote:
Btw you can use codecov: true to make it a little simpler. But don't know
why it doesn't run on master.
lanl-ansi/Juniper.jl#154
<lanl-ansi/Juniper.jl#154>
Our script line looks a bit different as well:
script:
- julia --project=docs -e 'using Pkg; Pkg.instantiate(); Pkg.add(PackageSpec(path=pwd()))'
- julia --project=docs --color=yes docs/make.jl
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#158 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABO2TUISNKOFPXEMJB2WJLRKS5CBANCNFSM4L2QVQ7A>
.
--
Dr. David P. Sanders
Profesor Titular "B" / Associate Professor
Departamento de Física, Facultad de Ciencias
Universidad Nacional Autónoma de México (UNAM)
dpsanders@g <dpsanders@ciencias.unam.mx>mail.com / Twitter: @davidpsanders
<https://twitter.com/DavidPSanders>
http://sistemas.fciencias.unam.mx/~dsanders / GitHub: dpsanders
<https://github.com/dpsanders>
Cubículo / office: #414, 4o. piso del Depto. de Física
Tel.: (+52 55) 5622 4965
|
|
Are you interested in using GitHub actions? Not sure why you need the |
|
df2c830 introduced an invalid config, you can see the warnings here: https://travis-ci.org/github/JuliaIntervals/IntervalConstraintProgramming.jl/builds/670193560/config?utm_medium=notification&utm_source=github_status |
|
Thanks, but the documentation was not running before that change. |
|
Yes it was, 592a8b6 (the commit just before df2c830) has a doc run here: https://travis-ci.org/github/JuliaIntervals/IntervalConstraintProgramming.jl/builds/670186062?utm_medium=notification&utm_source=github_status |
3 participants
Some things still missing:
The 3D torus image is missing as well as the corresponding jupyter notebook