class_for_name / Class.forName#62
Merged
aviks merged 1 commit intoJuliaInterop:masterfrom Jul 13, 2017
Merged
Conversation
Collaborator
|
Thanks! Most method names in this package are either camelCase or allruntogether. So the underscrores seems out of place here. Should this be called |
Collaborator
Author
|
Initially I thought allruntogether name would be unreadable, but after you've actually written it, it looks fine. Updated the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Class.forName(name)from JavaCall fails , most likely because default class loader doesn't respect a classpath, however callingClass.forName(name, true, classLoader)works fine. This PR provides a convenient wrapper functionclass_for_namefor it.