Fix JNIVector garbage collection, check if JVM destroyed#163
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=========================================
Coverage ? 64.43%
=========================================
Files ? 10
Lines ? 984
Branches ? 0
=========================================
Hits ? 634
Misses ? 350
Partials ? 0 Continue to review full report at Codecov.
|
Member
Author
|
The JNI module should be fixed so that one can just pass the array rather than explicitly having to extract the pointer via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
own = falsewithunsafe_wrapsince Java should free the array, not JuliaRelease*cc: @ahnlabb