Improve documentation; fix gplothtml; add TagBot#174
Merged
Conversation
-distinguish args, kwargs -add missing kwargs
clarify that Cairo is required to visualize in vscode
Checking for System OS was outdated
hdavid16
changed the title
gplot docstringgplothtml
Now matches gadfly.jl (https://github.com/GiovineItalia/Gadfly.jl/blob/master/src/open_file.jl)
-allow gplothtml to accept same arguments as gplot -allow x/y-locs to be of different type (<: Real)
hdavid16
changed the title
gplothtmlgplothtml; add TagBot
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 33.11% 32.92% -0.20%
==========================================
Files 9 9
Lines 456 565 +109
==========================================
+ Hits 151 186 +35
- Misses 305 379 +74
Help us with your feedback. Take ten seconds to tell us how you rate us. |
etiennedeg
approved these changes
Jul 26, 2022
Member
|
I think this should not be controversial, so I merge |
Contributor
Author
|
Thanks @etiennedeg. Next time we get a patch release registered with JuliaRegistrator, we'll hopefully get the repo version updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-distinguish between args, kwargs
-add missing kwargs
-fix bug in
gplothtml-enable
gplothtmlto accept same input asgplot-add TagBot workflow