Run gcscrub after warmup and remove unnecessary gc run for first sample #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willow-ahrens
requested changes
May 3, 2024
Collaborator
willow-ahrens
left a comment
willow-ahrens
left a comment
There was a problem hiding this comment.
Pending the small change to what "counts" towards sampling time, this looks good to me.
willow-ahrens
approved these changes
May 3, 2024
Collaborator
willow-ahrens
left a comment
willow-ahrens
left a comment
There was a problem hiding this comment.
looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, moved trial construction before gcscrub as it's mutable.