Skip to content

Fix bug in ValidatedEmail method __eq__() #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshData merged 3 commits into from
Sep 22, 2021
Merged

Fix bug in ValidatedEmail method __eq__() #66

JoshData merged 3 commits into from
Sep 22, 2021

Conversation

@yassam
Copy link
Contributor

@yassam yassam commented Sep 21, 2021

There's a bug in method __eq__() of ValidatedEmail. It doesn't check whether other is an instance of type ValidatedEmail, so the following fails:

>>> from email_validator import validate_email
>>> v = validate_email('foo@test.com')
>>> v == "hello"
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/yhassan/source/deferit/deferit/.env/lib/python3.8/site-packages/email_validator/__init__.py", line 146, in __eq__
    self.email == other.email
AttributeError: 'str' object has no attribute 'email'

Now checks parameter other is an instance of ValidatedEmail before checking all its members are equal to self's members.

@yassam
Fix bug in ValidatedEmail method __eq__()
791ddd2 
Check parameter `other` is an instance of ValidatedEmail before
checking all its members are equal to self's members.
@yassam yassam mentioned this pull request Sep 21, 2021
Closed
@JoshData JoshData merged commit fbcf145 into JoshData:primary Sep 22, 2021
@JoshData
Copy link
Owner

JoshData commented Sep 22, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yassam @JoshData